Finished model with error cases and a few comments

models/connector.class.php

@@ -36,6 +36,13 @@ class Connector {
         $this->bdd->setAttribute(PDO::ATTR_DEFAULT_FETCH_MODE, PDO::FETCH_ASSOC);
     }
 
+    /**
+     * @param string $fields Fields to select
+     * @param string $tables Tables to select from
+     * @param mixed[] $options Array filled with the selection options, such as "WHERE", "ORDER BY" and "LIMIT"
+     * @return mixed[]|null Array of values if the request went OK, NULL else
+     * @throws InvalidArgumentException There was an error within the arguments array
+     */
     function Select($fields, $tables, $options = array()) {
         $request = "SELECT $fields FROM $tables ";
         $arrayVerif = array();
@@ -44,7 +51,7 @@ class Connector {
                 $whereClause = " $upName ";
                 foreach($value as $array) {
                     if(sizeof($array) != 3 && sizeof($array) != 4) {
-                        throw new Exception("wrong_arg_nmbr_where");
+                        throw new InvalidArgumentException("wrong_arg_nmbr_where");
                     }
                     if(sizeof($array) == 3) {
                         $whereClause .= $array[0]." ".$array[1]." ? AND ";
@@ -57,7 +64,7 @@ class Connector {
                 $request .= substr($whereClause, 0, -5);
             } else if(($upName = strtoupper($name)) == "ORDER BY") {
                 if(sizeof($value) != 2 && substr($value[0], -2) != "()") {
-                    throw new Exception("wrong_arg_nmbr_order_by");
+                    throw new InvalidArgumentException("wrong_arg_nmbr_order_by");
                 }
 
                 $request .= " ".$upName." ".implode(" ", $value);
@@ -70,10 +77,10 @@ class Connector {
                     // nombre de champs
                     $request .= " $upName ".$value[0].",".$value[1];
                 } else {
-                    throw new Exception("wrong_arg_numbr_limit");
+                    throw new InvalidArgumentException("wrong_arg_numbr_limit");
                 }
             } else {
-                throw new Exception("unknown_arg");
+                throw new InvalidArgumentException("unknown_arg");
             }
         }
 
@@ -86,6 +93,10 @@ class Connector {
         }
     }
 
+    /**
+     * @param string $table Name of the table where the insertion takes place
+     * @param string[] $values Array of values to insert in the database
+     */
     function Insert($table, $values) {
         $request = "INSERT INTO $table(";
         $valeurs = "VALUES(";
@@ -103,6 +114,11 @@ class Connector {
         $stmt->execute($arrayVerif);
     }
 
+    /**
+     * @param string $table Name of the table where the update takes place
+     * @param mixed[] $update Array of fields to update with new values, with a "set"
+     *                          row filled with values, and a "where" row with conditions
+     */
     function Update($table, $update) {
         $request = "UPDATE $table SET ";
         $arrayVerif = array();
@@ -121,6 +137,10 @@ class Connector {
         $stmt->execute($arrayVerif);
     }
 
+    /**
+     * @param string $table Name of the table where the deletion takes place
+     * @param mixed[] $where Array of conditions to select the right row(s) to delete
+     */
     function Delete($table, $where = array()) {
         $request = "DELETE FROM $table";
         $arrayVerif = array();

models/data.class.php

@@ -25,7 +25,7 @@ class Data
 
         if($data == NULL)
         {
-            throw new Exception("Les données n'existent pas");
+            throw new LengthException("Les données n'existent pas");
         }
 
         // Chargement des informations
@@ -177,6 +177,11 @@ class Data
             )
         ))[0];
 
+        if(!$data)
+        {
+            throw new UnexpectedValueException("Les données n'existent plus en base de données");
+        }
+
         $attrs = get_object_vars($this);
         $toUpdate = array();
 
@@ -197,6 +202,11 @@ class Data
         $bdd = new Connector();
         $data = $bdd->Select("*", "data");
 
+        if(!$data)
+        {
+            throw new LengthException("Aucune donnée présente en base de données");
+        }
+
         $csv = "";
 
         // Head line

models/file.class.php

@@ -21,7 +21,7 @@ class File
 
         if(!$document)
         {
-            throw new Exception("Le fichier n'existe pas");
+            throw new LengthException("Le fichier n'existe pas");
         }
 
         $this->id = $document["id"];
@@ -33,6 +33,13 @@ class File
 
     public static function addDocument($document)
     {
+        foreach($document as $key=>$value)
+        {
+            if(empty($value) && $key != "promo" && $key != "id")
+            {
+                throw InvalidArgumentException("La colonne `".$key."` doit être définie");
+            }
+        }
         $bdd = new Connector();
         $bdd->Insert("document", array(
             "id" => $document["id"],
@@ -63,7 +70,7 @@ class File
 
         if(!$promo)
         {
-            throw new Exception("La promo n'existe pas");
+            throw new LengthException("La promo n'existe pas");
         }
 
         // Change promo in both object and BDD

models/promo.class.php

@@ -18,7 +18,7 @@ class Promo
 
         if($promo == NULL)
         {
-            throw new Exception("La promo n'existe pas");
+            throw new LengthException("La promo n'existe pas");
         }
 
         $this->id_promo = $promo["id_promo"];
@@ -73,6 +73,11 @@ class Promo
             )
         ))[0];
 
+        if(!$promo)
+        {
+            throw new UnexpectedValueException("La promo n'existe plus en base de données");
+        }
+
         $attrs = get_object_vars($this);
         $toUpdate = array();